mirror/moodle-auth_emailotp
1
0
Fork 0
mirror of https://github.com/PawelSuwinski/moodle-auth_emailotp.git synced 2026-05-16 21:41:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

apply local_codechecker recomendations

Browse Source
This commit is contained in:
Paweł Suwiński
2020-11-18 15:04:19 +01:00
parent 03680da8f0
commit 15450e8eec
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
auth.php
View File

@@ -244,11 +244,11 @@ class auth_plugin_emailotp extends auth_plugin_base {
*/
protected function min_request_period_fulfilled(string $email) {
// Min request period security disabled.
if(empty($this->config->minrequestperiod)) {
if (empty($this->config->minrequestperiod)) {
return true;
}
// Log reader required - silently return failure on absence.
if(!$reader = reset(get_log_manager()->get_readers('\core\log\sql_reader'))) {
if (!$reader = reset(get_log_manager()->get_readers('\core\log\sql_reader'))) {
return false;
}
return $reader->get_events_select_count(

8
settings.php
View File

@@ -52,7 +52,7 @@ if ($ADMIN->fulltree) {
get_string('fieldsmapping_mapping', 'auth_emailotp'),
get_string('fieldsmapping_mapping_help', 'auth_emailotp'), '', PARAM_RAW_TRIMMED));
$settings->add(new admin_setting_heading('auth_emailotp/security',
$settings->add(new admin_setting_heading('auth_emailotp/security',
new lang_string('security', 'admin'), ''));
$settings->add(new admin_setting_configtext('auth_emailotp/revokethreshold',
@@ -65,9 +65,9 @@ if ($ADMIN->fulltree) {
get_string('minrequestperiod_help', 'auth_emailotp')
) extends admin_setting_configtext {
public function __construct($name, $visiblename, $description) {
$log_reader = reset(get_log_manager()->get_readers('\core\log\sql_reader'));
parent::__construct($name, $visiblename, $description, $log_reader ? 120 : 0, PARAM_INT);
if(!$log_reader && !empty($this->get_setting())) {
$logreader = reset(get_log_manager()->get_readers('\core\log\sql_reader'));
parent::__construct($name, $visiblename, $description, $logreader ? 120 : 0, PARAM_INT);
if (!$logreader && !empty($this->get_setting())) {
$this->description .= ' '.get_string('logstorerequired', 'auth_emailotp',
(string)new moodle_url('/admin/settings.php', ['section' => 'managelogging'])
);