From 15450e8eec0acbd00c8192bab93378a2b486f4f4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Pawe=C5=82=20Suwi=C5=84ski?= <dracono@wp.pl>
Date: Wed, 18 Nov 2020 15:04:19 +0100
Subject: [PATCH] apply local_codechecker recomendations

---
 auth.php     | 4 ++--
 settings.php | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/auth.php b/auth.php
index 313f66f..656df4b 100644
--- a/auth.php
+++ b/auth.php
@@ -244,11 +244,11 @@ class auth_plugin_emailotp extends auth_plugin_base {
      */
     protected function min_request_period_fulfilled(string $email) {
         // Min request period security disabled.
-        if(empty($this->config->minrequestperiod)) {
+        if (empty($this->config->minrequestperiod)) {
             return true;
         }
         // Log reader required - silently return failure on absence.
-        if(!$reader = reset(get_log_manager()->get_readers('\core\log\sql_reader'))) {
+        if (!$reader = reset(get_log_manager()->get_readers('\core\log\sql_reader'))) {
             return false;
         }
         return $reader->get_events_select_count(
diff --git a/settings.php b/settings.php
index 48c260c..ae1451e 100644
--- a/settings.php
+++ b/settings.php
@@ -52,7 +52,7 @@ if ($ADMIN->fulltree) {
         get_string('fieldsmapping_mapping', 'auth_emailotp'),
         get_string('fieldsmapping_mapping_help', 'auth_emailotp'), '', PARAM_RAW_TRIMMED));
 
-   $settings->add(new admin_setting_heading('auth_emailotp/security',
+    $settings->add(new admin_setting_heading('auth_emailotp/security',
         new lang_string('security', 'admin'), ''));
 
     $settings->add(new admin_setting_configtext('auth_emailotp/revokethreshold',
@@ -65,9 +65,9 @@ if ($ADMIN->fulltree) {
         get_string('minrequestperiod_help', 'auth_emailotp')
     ) extends admin_setting_configtext {
         public function __construct($name, $visiblename, $description) {
-            $log_reader = reset(get_log_manager()->get_readers('\core\log\sql_reader'));
-            parent::__construct($name, $visiblename, $description, $log_reader ? 120 : 0, PARAM_INT);
-            if(!$log_reader && !empty($this->get_setting())) {
+            $logreader = reset(get_log_manager()->get_readers('\core\log\sql_reader'));
+            parent::__construct($name, $visiblename, $description, $logreader ? 120 : 0, PARAM_INT);
+            if (!$logreader && !empty($this->get_setting())) {
                 $this->description .= ' '.get_string('logstorerequired', 'auth_emailotp',
                     (string)new moodle_url('/admin/settings.php', ['section' => 'managelogging'])
                 );