Solving all warnings from moodle-plugin-ci check.

classes/outagelib.php

@@ -57,7 +57,6 @@ class outagelib {
      */
     public static function inject() {
         global $CFG;
-        global $PAGE;
 
         // Many hooks can call it, execute only once.
         if (self::$initialized) {
@@ -69,8 +68,6 @@ class outagelib {
             return;
         }
 
-        // FIXME Code below is raising error at http://moodle.test/my/ for example.
-        // $PAGE->add_body_class('auth_outage_active');
         $CFG->additionalhtmltopofbody = self::get_renderer()->renderbar($active)
             . $CFG->additionalhtmltopofbody;
     }

db/upgrade.php

@@ -0,0 +1,34 @@
+<?php
+// This file is part of Moodle - http://moodle.org/
+//
+// Moodle is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// Moodle is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with Moodle.  If not, see <http://www.gnu.org/licenses/>.
+
+/**
+ * Outage plugin upgrade code
+ *
+ * @package    auth_outage
+ * @author     Daniel Thee Roperto <daniel.roperto@catalyst-au.net>
+ * @copyright  Catalyst IT
+ * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
+ */
+defined('MOODLE_INTERNAL') || die();
+
+/**
+ * @param int $oldversion the version we are upgrading from
+ * @return bool result
+ * @SuppressWarnings("unused")
+ */
+function xmldb_auth_outage_upgrade($oldversion) {
+    return true;
+}

res/outage.css

@@ -1,19 +1,19 @@
 .auth_outage_warningbar {
-    box-sizing: content-box;
-    position: fixed;
-    top: 0px;
-    left: 0px;
-    height: 90px;
-    z-index: 9999;
-    width: 100%;
-    text-align: center;
     background-color: white;
+    box-sizing: content-box;
+    height: 90px;
+    left: 0;
+    position: fixed;
+    text-align: center;
+    top: 0;
+    width: 100%;
+    z-index: 9999;
 }
 
 .auth_outage_warningbar_box {
-    border-top: 2px dashed #a00000;
-    border-bottom: 2px dashed #a00000;
     background-color: #ffcccc;
+    border-bottom: 2px dashed #a00000;
+    border-top: 2px dashed #a00000;
     color: #a00000;
 }