mirror/moodle-auth_outage
1
0
Fork 0
mirror of https://github.com/catalyst/moodle-auth_outage.git synced 2026-05-17 05:48:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

Issue #46 - Fixed moodle-plugin-ci warnings.

Browse Source
This commit is contained in:
Daniel Thee Roperto
2016-09-26 11:17:57 +10:00
parent 909b4bbcd3
commit b79a70d122
3 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
classes/local/cli/clibase.php
View File

@@ -20,7 +20,6 @@ use coding_exception;
use core\session\manager;
defined('MOODLE_INTERNAL') || die();
require_once($CFG->libdir.'/clilib.php');
/**
* Outage CLI base class.
@@ -48,6 +47,8 @@ abstract class clibase {
*/
public function __construct(array $options = null) {
global $CFG;
require_once($CFG->libdir.'/clilib.php');
if (!is_enabled_auth('outage')) {
throw new cli_exception(get_string('cliplugindisabled', 'auth_outage'), cli_exception::ERROR_PLUGIN_DISABLED);
}

11
tests/behat/behat_auth_outage.php
View File

@@ -27,9 +27,6 @@
use auth_outage\dml\outagedb;
use auth_outage\local\outage;
use Behat\Behat\Tester\Exception\PendingException;
use Behat\Gherkin\Node\TableNode;
use Behat\Mink\Exception\ElementNotFoundException;
use Behat\Mink\Exception\ExpectationException;
require_once(__DIR__.'/../../../../lib/behat/behat_base.php');
@@ -59,8 +56,8 @@ class behat_auth_outage extends behat_base {
$this->getSession()->visit($this->locate_path('login/index.php'));
// Enter username and password.
$this->execute('behat_forms::i_set_the_field_to', array('Username', $this->escape('admin')));
$this->execute('behat_forms::i_set_the_field_to', array('Password', $this->escape('admin')));
$this->execute('behat_forms::i_set_the_field_to', ['Username', $this->escape('admin')]);
$this->execute('behat_forms::i_set_the_field_to', ['Password', $this->escape('admin')]);
// Press log in button, no need to check for exceptions as it will checked after this step execution.
$this->execute('behat_forms::press_button', get_string('login'));
@@ -139,7 +136,7 @@ class behat_auth_outage extends behat_base {
private function can_i_see_action($action) {
$selector = 'css';
$locator = "div[role='main'] a[title='${action}']";
$locator = "div[role='main'] a[title='".$action."']";
$items = $this->getSession()->getPage()->findAll($selector, $locator);
return count($items);
}
@@ -148,7 +145,7 @@ class behat_auth_outage extends behat_base {
* @Then I click on the :action action button
*/
public function i_click_on_the_action_button($action) {
$node = $this->get_selected_node('css_element', "div[role='main'] table nobr a[title='${action}']");
$node = $this->get_selected_node('css_element', "div[role='main'] table nobr a[title='".$action."']");
$this->ensure_node_is_visible($node);
$node->click();
}

4
tests/phpunit/cli/cli_test.php
View File

@@ -89,7 +89,7 @@ class cli_test extends cli_testcase {
set_config('auth', '');
\core\session\manager::gc(); // Remove stale sessions.
core_plugin_manager::reset_caches();
// Try to create an CLI
$cli = new create();
// Try to create an CLI object.
new create();
}
}