mirror/moodle-auth_outage
1
0
Fork 0
mirror of https://github.com/catalyst/moodle-auth_outage.git synced 2026-05-17 05:48:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

Issue #9 - Fixed outagedb::getactive() to make better usage of Moodle DB API, removing hardcoded LIMIT from SQL Query.

Browse Source
This commit is contained in:
Daniel Thee Roperto
2016-09-07 09:51:48 +10:00
parent abe029afce
commit 68cfce9b48
1 changed files with 11 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
classes/outagedb.php
View File

@@ -154,20 +154,21 @@ final class outagedb {
throw new \InvalidArgumentException('$time must be null or an int.');
}
// TODO Is there a way to use Moodle API instead of writing SQL (conditions not equals)?
// TODO Query not fully using indexes (starttime + 90)
// Gets any active outage (already started or during warning period).
// Gets only one record if available, the one that starts(ed) first and that stops last.
$data = $DB->get_record_sql('
SELECT *
FROM {auth_outage}
WHERE (starttime - warningduration <= :datetime1 AND stoptime >= :datetime2)
ORDER BY starttime ASC, stoptime DESC, title ASC
LIMIT 1
',
['datetime1' => $time, 'datetime2' => $time]
$data = $DB->get_records_select(
'auth_outage',
'(starttime - warningduration <= :datetime1 AND stoptime >= :datetime2)',
['datetime1' => $time, 'datetime2' => $time],
'starttime ASC, stoptime DESC, title ASC',
'*',
0,
1
);
return ($data === false) ? null : new \auth_outage\models\outage($data);
// Not using $DB->get_record_select instead because there is no 'limit' parameter.
// Allowing multiple records still raises an internal error.
return (count($data) == 0) ? null : new \auth_outage\models\outage(array_shift($data));
}
}