mirror/moodle-auth_emailotp
1
0
Fork 0
mirror of https://github.com/PawelSuwinski/moodle-auth_emailotp.git synced 2026-05-16 21:41:27 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix notice only variables should be passed by reference

Browse Source
This commit is contained in:
Paweł Suwiński
2020-11-26 09:10:36 +01:00
parent 6d9b5f8300
commit 50699c4caa
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
auth.php
View File

@@ -239,10 +239,9 @@ class auth_plugin_emailotp extends auth_plugin_base {
return true; return true;
} }
// Log reader required - silently return failure on absence. // Log reader required - silently return failure on absence.
if (!$reader = reset(get_log_manager()->get_readers('\core\log\sql_reader'))) { $readers = get_log_manager()->get_readers('\core\log\sql_reader');
return false; $reader = reset($readers);
} return $reader && $reader->get_events_select_count(
return $reader->get_events_select_count(
'component = ? AND action = ? AND timecreated >= ? AND other = ?', 'component = ? AND action = ? AND timecreated >= ? AND other = ?',
array( array(
self::COMPONENT_NAME, self::COMPONENT_NAME,

3
settings.php
View File

@@ -65,7 +65,8 @@ if ($ADMIN->fulltree) {
get_string('minrequestperiod_help', 'auth_emailotp') get_string('minrequestperiod_help', 'auth_emailotp')
) extends admin_setting_configtext { ) extends admin_setting_configtext {
public function __construct($name, $visiblename, $description) { public function __construct($name, $visiblename, $description) {
$logreader = reset(get_log_manager()->get_readers('\core\log\sql_reader')); $readers = get_log_manager()->get_readers('\core\log\sql_reader');
$logreader = reset($readers);
parent::__construct($name, $visiblename, $description, $logreader ? 120 : 0, PARAM_INT); parent::__construct($name, $visiblename, $description, $logreader ? 120 : 0, PARAM_INT);
if (!$logreader && !empty($this->get_setting())) { if (!$logreader && !empty($this->get_setting())) {
$this->description .= ' '.get_string('logstorerequired', 'auth_emailotp', $this->description .= ' '.get_string('logstorerequired', 'auth_emailotp',