From 50699c4caaa5f4f7c7d0a95f8859fcb2e304f78a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pawe=C5=82=20Suwi=C5=84ski?= Date: Thu, 26 Nov 2020 09:10:36 +0100 Subject: [PATCH] fix notice only variables should be passed by reference --- auth.php | 7 +++---- settings.php | 3 ++- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/auth.php b/auth.php index ce0391e..6069474 100644 --- a/auth.php +++ b/auth.php @@ -239,10 +239,9 @@ class auth_plugin_emailotp extends auth_plugin_base { return true; } // Log reader required - silently return failure on absence. - if (!$reader = reset(get_log_manager()->get_readers('\core\log\sql_reader'))) { - return false; - } - return $reader->get_events_select_count( + $readers = get_log_manager()->get_readers('\core\log\sql_reader'); + $reader = reset($readers); + return $reader && $reader->get_events_select_count( 'component = ? AND action = ? AND timecreated >= ? AND other = ?', array( self::COMPONENT_NAME, diff --git a/settings.php b/settings.php index ae1451e..e19791b 100644 --- a/settings.php +++ b/settings.php @@ -65,7 +65,8 @@ if ($ADMIN->fulltree) { get_string('minrequestperiod_help', 'auth_emailotp') ) extends admin_setting_configtext { public function __construct($name, $visiblename, $description) { - $logreader = reset(get_log_manager()->get_readers('\core\log\sql_reader')); + $readers = get_log_manager()->get_readers('\core\log\sql_reader'); + $logreader = reset($readers); parent::__construct($name, $visiblename, $description, $logreader ? 120 : 0, PARAM_INT); if (!$logreader && !empty($this->get_setting())) { $this->description .= ' '.get_string('logstorerequired', 'auth_emailotp',