mirror/moodle-auth_outage
1
0
Fork 0
mirror of https://github.com/catalyst/moodle-auth_outage.git synced 2026-05-17 05:48:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

Basic form validation for create/edit outage. Checks if starttime is in past, stoptime is after starttime, warningduration is not zero and title size. Issue #7.

Browse Source
This commit is contained in:
Daniel Thee Roperto
2016-09-05 15:01:22 +10:00
parent 6055f52d64
commit 98de8a6c69
6 changed files with 51 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
classes/forms/outage/edit.php
View File

@@ -31,6 +31,8 @@ require_once($CFG->libdir . '/formslib.php');
* @license http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
*/
class edit extends \moodleform {
const TITLE_MAX_CHARS = 100;
/**
* {@inheritDoc}
* @see moodleform::definition()
@@ -47,7 +49,12 @@ class edit extends \moodleform {
$mform->addElement('duration', 'warningduration', get_string('warningduration', 'auth_outage'));
$mform->addElement('text', 'title', get_string('title', 'auth_outage'));
$mform->addElement(
'text',
'title',
get_string('title', 'auth_outage'),
'maxlength="'.self::TITLE_MAX_CHARS.'"'
);
$mform->setType('title', PARAM_TEXT);
$mform->addElement('editor', 'description', get_string('description', 'auth_outage'));
@@ -65,6 +72,24 @@ class edit extends \moodleform {
public function validation($data, $files) {
$errors = parent::validation($data, $files);
if ($data['starttime'] <= time()) {
$errors['starttime'] = get_string('starttimeerrornotinfuture', 'auth_outage');
}
if ($data['stoptime'] <= $data['starttime']) {
$errors['stoptime'] = get_string('stoptimeerrornotafterstart', 'auth_outage');
}
if ($data['warningduration'] <= 0) {
$errors['warningduration'] = get_string('warningdurationerrorinvalid', 'auth_outage');
}
$titlelen = strlen(trim($data['title']));
if ($titlelen == 0) {
$errors['title'] = get_string('titleerrorinvalid', 'auth_outage');
}
if ($titlelen > self::TITLE_MAX_CHARS) {
$errors['title'] = get_string('titleerrortoolong', 'auth_outage', self::TITLE_MAX_CHARS);
}
return $errors;
}

2
classes/outagedb.php
View File

@@ -98,7 +98,7 @@ final class outagedb {
['objectid' => $outage->id, 'other' => (array)$outage]
)->trigger();
} else {
// Not new, clean up the class (remove creator field) then update.
// Remove the createdby field so it does not get updated.
unset($outage->createdby);
$DB->update_record('auth_outage', $outage);
// Log it.