Issue #12 - fixed code standard problems preventing Travis to build.

This commit is contained in:
Daniel Thee Roperto
2016-09-02 15:38:19 +10:00
parent 6ceb328aa4
commit 18e0583ba5
7 changed files with 11 additions and 41 deletions

View File

@@ -35,7 +35,7 @@ class outage_test extends basic_testcase
// Very important, this should never change.
self::assertNull($outage->id, 'New empty outage can never have an id set.');
// Ensure all other fields are also null.
foreach ($outage as $k=>$v) {
foreach ($outage as $v) {
self::assertNull($v);
}
}

View File

@@ -31,44 +31,22 @@ defined('MOODLE_INTERNAL') || die();
class outagelib_test extends basic_testcase
{
public function test_data2object() {
// Using object data, no new fields, not strict.
// Using object data, no new fields.
$obj = new stdClass();
$obj->foo = 'bar';
$obj->number = 42;
$data = new stdClass();
$data->foo = 'not bar';
outagelib::data2object($data, $obj, false);
outagelib::data2object($data, $obj);
self::assertEquals(get_object_vars($obj), ['foo' => 'not bar', 'number' => 42], 'Invalid result.');
self::assertEquals(get_object_vars($data), ['foo' => 'not bar'], 'Data should not change.');
// Using array data, with new fields, not strict.
// Using array data, with new fields.
$obj = new stdClass();
$obj->foo = 'bar';
$obj->number = 42;
$data = ['foo' => 'foobar', 'flag' => false];
outagelib::data2object($data, $obj, false);
outagelib::data2object($data, $obj);
self::assertEquals(get_object_vars($obj), ['foo' => 'foobar', 'number' => 42], 'Invalid result.');
// Using object data, no new fields, strict.
$obj = new stdClass();
$obj->foo = 'bar';
$obj->number = 42;
$data = new stdClass();
$data->foo = 'not bar';
outagelib::data2object($data, $obj, true);
self::assertEquals(get_object_vars($obj), ['foo' => 'not bar', 'number' => 42], 'Invalid result.');
self::assertEquals(get_object_vars($data), ['foo' => 'not bar'], 'Data should not change.');
// Using array data, with new fields, strict.
$obj = new stdClass();
$obj->foo = 'bar';
$obj->number = 42;
$data = ['foo' => 'foobar', 'flag' => false];
try {
outagelib::data2object($data, $obj, true);
$this->fail('Exception was expected.');
}
catch (InvalidArgumentException $e){
}
}
}