Issue #12 - fixed code standard problems preventing Travis to build.

This commit is contained in:
Daniel Thee Roperto
2016-09-02 15:38:19 +10:00
parent 6ceb328aa4
commit 18e0583ba5
7 changed files with 11 additions and 41 deletions

View File

@@ -53,7 +53,6 @@ class delete extends \moodleform {
*/
public function validation($data, $files) {
$errors = parent::validation($data, $files);
$mform = $this->_form;
return $errors;
}

View File

@@ -64,7 +64,6 @@ class edit extends \moodleform {
*/
public function validation($data, $files) {
$errors = parent::validation($data, $files);
$mform = $this->_form;
return $errors;
}

View File

@@ -47,9 +47,8 @@ class outagelib
*
* @param $data mixed An object or array.
* @param $obj object Destination object to write the properties.
* @param $strict bool All data fields must be used in the destination object or an exception will be thrown.
*/
public static function data2object($data, $obj, $strict = false) {
public static function data2object($data, $obj) {
if (is_object($data)) {
$data = get_object_vars($data);
}
@@ -59,16 +58,9 @@ class outagelib
if (!is_object($obj)) {
throw new \InvalidArgumentException('$obj must be an object.');
}
if (!is_bool($strict)) {
throw new \InvalidArgumentException('$strict must be a bool.');
}
foreach ($data as $k => $v) {
if (!property_exists($obj, $k)) {
if ($strict) {
throw new \InvalidArgumentException('$obj does not have a property called ' . $k);
}
} else {
if (property_exists($obj, $k)) {
if (method_exists($obj, $k)) {
throw new \InvalidArgumentException('$obj has a method called ' . $k);
}